Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Ok, a review of the code:

I increased the sleep to 10 seconds, 1 second is pushing it.

Double return of the same value in the tail of GetFavoriteSubmitters so you can drop two lines there.

Maybe add a linefeed at the end of every row of users so you can still make sense of it in a text editor ?

Missing 'close' at the end of the writing of the file. Sure, the file will be closed by the script that exits but that's sloppy.

That's about it.

The results:

  edw519	5
  yarapavan	4
  fogus	4    
  amichail	4
  zjj	2
  prabodh	2
  nopassrecover	2
  dreemteem	2
  boundlessdreamz	2
All the rest of them are 'one-offs'. I guess I'm not much of a groupie :)


Thank you for your feedback, Jacque! I'll change the script accordingly.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: