On: Stepping down as Mockito maintainer after ten years

[wiseowise]

> But third-party IO is exactly the thing you'd want to mock.

You write an adapter.

[throwaway7375 → wiseowise]

Once you start writing adapters you need a way to instantiate them to choose between implementations, and factories is often used for this. Then you might generalize the test suites to make the setup easier and you end up with the infamous FactoryFactory pattern.

[deepsun → wiseowise]

No, some other library classes accept only their own, not my adapter.

Not mentioning of course needless copy-pasting dosens of members in the adapter. And it must be in prod code, not tests, even though it's documentation would say "Adapter for X, exists only for tests, to be able to mock X".

[wiseowise → deepsun]

You wrap whole 3rd party dependency in an adapter.

[akoboldfrying → wiseowise]

That's a lot of upfront work and maintenance, not to mention the friction of needing to mentally translate every occurrence of OurFooAdapter to Foo in order to find documentation.

[wiseowise → akoboldfrying]

Yeah, well, good code takes some thought to produce. More news at 11.

[deepsun → wiseowise]

The second argument still holds -- all those wrappers will exist in prod only for tests.

Moreover, that wrapper library is now a pretty large piece of code, and we'd want to maintain and test as well. But cannot without hacks.

[deepsun → wiseowise]

I think it's easier to unpack/remove-"final"/re-compile the library .jar during the build time. Will be more stable to any changes than an adapter.