On: Ask HN: Is it acceptable to put up large pull requ...

[syndicatedjelly]

Yes 1500 line PRs that are anything other than trivial changes are not acceptable. Please tell me you guys aren’t squashing commits on merge too

[flustercan → syndicatedjelly]

It wouldn't matter in this case. Its usually 1 1500 line commit in a PR, or its a couple of commits but they aren't meaningful ("write large feature", "review updates", "wip", "merge branch X", etc)

[syndicatedjelly → flustercan]

Why are people writing junk commits like that? Tell them not to

[flustercan → syndicatedjelly]

Some people consider the PR the unit of work, not the commit. I don't really agree but I think its a reasonable way to do things if you are squashing the PR before merging. The problem is the size.

[lysace → syndicatedjelly]

> Please tell me you guys aren’t squashing commits on merge too

We (different org) aren't. We really should, huh?

[syndicatedjelly → lysace]

No you really shouldn’t squash commits such that each one is hundreds of lines. That makes future debugging with git bisect pretty difficult

[lysace → syndicatedjelly]

On the other hand, on a larger scale, it's often more about figuring out what PR caused something to break, rather than exactly which of the 100 WIP commits inside that PR was the exact cause.