I struggle to see how any open-source project would accept this kind os PRs, the...

no_wizard · 2024-02-27T15:49:38 1709048978

I have to say, the maintainers handled it with grace though. Didn't sass the company for it or anything, politely declined the PR, closed it, locked it and moved on.

It reflects back on them really well.

I've never used Spring Boot, but I have to give them credit for this. I don't know that I'd have similar restraint

dartos · 2024-02-27T16:06:38 1709049998

Spring boot is one of the most enterprise-y frameworks I’ve used.

I’d be surprised if their team wasn’t incredibly professional.

delecti · 2024-02-27T15:44:49 1709048689

Agreed. This seems like rather shameless advertising at the expense of the labor of the project maintainers.

shaunxcode · 2024-02-27T15:49:39 1709048979

The comments are worthless too.

Things like a method called Foo that takes a Bar so the comment says (in 3 or 4 lines)

“Foo takes a Bar”

Wow! The future is here!