There are only 4 cases where I have a non optional comment:
* code has a bug
* code is not compliant with a style guide, API rubric, or similar
* architecture is flawed (usually due to skipping a design doc or review) it is introducing tech debt that wasn't agreed to take on
* missing test cases
Everything else is a suggestion I start with the word nit or consider. I leave it up to the author to decide what action to take. Most often they take the suggestion, but not always. It's never been a problem imo either way.
Everything else is a suggestion I start with the word nit or consider. I leave it up to the author to decide what action to take. Most often they take the suggestion, but not always. It's never been a problem imo either way.