I'm entire unfond of the NSA. The existence of secret agencies, especially on a large scale, make a mockery of democracy.
At the same, government by congressional hobbling and sabotage also makes a mockery of democracy through agencies not ceasing bad behavior but rather a continuous war between congress and agencies being normalized in a way that makes agencies actually more autonomous from congress. The "Washington Monument Syndrome" is just one piece of the problematic situation [1].
Security through obscurity is inferior to security through transparency. Imagine if every interaction with the government; every contract, negotiation, communication was a matter of easily searchable public record.
Try sneaking a little graft in there and get laughed at in public. It'd be great.
So if a foreign agent is providing us information about their government, that relationship should be in the public record? That seems like a really good way to ensure you have no human intelligence sources at all.
We should reveal every detail about our military's weapons systems so our adversaries can more easily build countermeasures against them?
It seems exceedingly unrealistic that any government, even a democracy, could keep no secrets at all and survive.
The reason the NSA conducts its activities in secret have little to do with "a little graft" and everything to do with the fact you don't show somebody you've broken their ciphers unless you have to.
They won't show what they have access to and actively use against adversaries. They have "NSA approved cryptos" such as TACLANES hardware that other countries can use at government level with their own crypto bases. Civilian level encryption was never meant to be Government level, we were only lucky that AES and such was opened up by US law in the 1990s.
I'm having trouble seeing how that makes any sense.
When the Allies in WW2 broke Germany's Enigma cipher, are you suggesting that by not telling Germany that the Allies could now read a large fraction of Germany's military communication they were endangering their own national security?!
If the NSA has broken whatever cipher suite the GRU uses, or the Iranian RG, or whomever, please explain how keeping that fact a secret endangers the USA?
Keep in mind they share info with the other Five Eyes and select other allied nations.
At the same, government by congressional hobbling and sabotage also makes a mockery of democracy through agencies not ceasing bad behavior but rather a continuous war between congress and agencies being normalized in a way that makes agencies actually more autonomous from congress. The "Washington Monument Syndrome" is just one piece of the problematic situation [1].
[1] https://en.wikipedia.org/wiki/Washington_Monument_syndrome