"My main challenge is when people dig in their heels about technical solutions that I find distasteful"
I had co-workers that avoided me as a reviewer because I would highlight important tech and architectural concerns. Those were hand waved away with the usual "we don't have time" arguments.
They've since left the company and I've spent literal years pulling out those deeply embedded ticks.
I've come to realize that I should have asserted myself a lot more back then. You're right that many of the small things don't matter (or can be improved fairly easily). The big things: some of those matter a lot.
It can be hard for others (especially more junior devs) to see the good intention of trying to avoid future quagmires. That's been a bit of a challenge on my end.
Yeah, you have to decide "does this really matter in the long term?" If not, let it go. If it does, do your best to explain why.
I'm a huge fan of good interfaces with shitty code inside. You can always improve the code inside if you got the interface right. If you got the interface wrong you'll need to rewrite anyway.
I had co-workers that avoided me as a reviewer because I would highlight important tech and architectural concerns. Those were hand waved away with the usual "we don't have time" arguments.
They've since left the company and I've spent literal years pulling out those deeply embedded ticks.
I've come to realize that I should have asserted myself a lot more back then. You're right that many of the small things don't matter (or can be improved fairly easily). The big things: some of those matter a lot.
It can be hard for others (especially more junior devs) to see the good intention of trying to avoid future quagmires. That's been a bit of a challenge on my end.