Related to the article, although not directly to the main point ("Should GH bless the root of project forks"):
So - I looked at the pull request that was linked to as 'couldn't get our fixes upstream'.
I don't know the project, but I was totally lost when I read the commit messages in the pull request. Samples:
I fixed something
small change'
better idea
class custer method
much much better
no such thing as an error here.
In the end upstream was lost as well, which might or might not be related to patch size and - erm - a little mess?
I know Zac is doing some pretty cool stuff, but this seems like dumping code, i.e. looks careless to me.
Yes, this is my biggest issue. I don't squash my commits like I should but this comes from our company repo and just gets imported. I tend to look at the last commit and just compare diffs for feature branch.
I don't know the project, but I was totally lost when I read the commit messages in the pull request. Samples:
In the end upstream was lost as well, which might or might not be related to patch size and - erm - a little mess?I know Zac is doing some pretty cool stuff, but this seems like dumping code, i.e. looks careless to me.