The feature Apple proposed would only apply to files you were uploading to iCloud. Turning off iCloud photos prevented scanning.
The whole point of the Apple system was to enable end to end encryption so Apple couldn’t view your data on their servers. The only way they could get access is when a threshold of CSAM likely files were met. e.g the keys are sharded.
With the Apple approach you have considerably more privacy.
Why would they care about getting a foot in a door that they have the keys to and is wide open?
Modern SoCs have security domains that are invisible to the main CPUs. Apple can run just about anything it wants on the security coprocessor and users will be none the wiser.
The American DOJ, FBI etc do not want end-to-end encryption
and use ‘think of the children’ as an excuse. This gives Apple the plausible pushback to say ‘We have thought of the children…’
The whole point of the Apple system was to enable end to end encryption so Apple couldn’t view your data on their servers. The only way they could get access is when a threshold of CSAM likely files were met. e.g the keys are sharded.
With the Apple approach you have considerably more privacy.