I had some 360 controllers that lasted ~10 years, which seems pretty good for a controller. The rubber on the top of the joysticks wore away after maybe 7 or so years, and then they eventually became wobbly.
A ~4 year old Xbox one controller just got too much drift, surprisingly enough. I was kind of disappointed. But with these small sample sizes, could just be a fluke.
opposite for me. replaced many thumbsticks on 360 controllers, have had better luck with XBone. but, i kinda suspect the same cheapo parts are used on both, so...
DS4's have been solid for me, with the biggest issue being their rather disappointing battery life. Probably depends a lot on the types of games most often played, playstyles, etc though.