The different ways you're expressing the question give different meanings to your review. It's not clear to me what you want: are you blocking the review on extracting the code? Does this have to be done now or could this be on a separate patch? After or before the series? Is there an actual good reason to extract it (like you plan on using it tomorrow) or is this just about making the code easier to read?
- Try to make this not personal (opposite of how I started the paragraph above!). Talk about the code, not about what the author did. The code does this, the code does that, instead of you wrote this, you wrote that. Also, it's our code, so "we should do this" instead of "you should do that" in case you can't use "the code should do that".
- Be clear on what's just nice-to-have and what is really blocking the review process.
- Explain to them why you think this should be extracted to a separate function. Maybe they have a good reason against it or a good counter argument.
- Try to make this not personal (opposite of how I started the paragraph above!). Talk about the code, not about what the author did. The code does this, the code does that, instead of you wrote this, you wrote that. Also, it's our code, so "we should do this" instead of "you should do that" in case you can't use "the code should do that".
- Be clear on what's just nice-to-have and what is really blocking the review process.
- Explain to them why you think this should be extracted to a separate function. Maybe they have a good reason against it or a good counter argument.