SpaceX definitely wants to make a profit. I don't think building a city on Mars is profit maximization though and this is Elon's explicit reason for not taking SpaceX public.
> According to the company, the short-term demands of shareholders conflict with his long-term ambitions.