On: Surprisingly Slow

[nullify88]

I see this alot with Ansible. Its not particularly slow but running it places a bigger burden on laptop cpu and fans than I'd imagined.

[throwdbaaway → nullify88]

Noticed the same too. It is likely that we are both impacted by the very aggressive default of 1ms for `internal_poll_interval`: https://github.com/ceph/ceph-cm-ansible/pull/308

[mkj → throwdbaaway]

Huh, polling with a sleep() rather than a proper event wait seems like a bad code smell there...

[necheffa → mkj]

How so? This is almost certainly what the internals of a packaged event wait would look like.

[mkj → necheffa]

It could use a Queue of some kind rather than just pushing onto a deque between threads [1]? Then it would idly wait for the results_thread_main to push results.

I guess that might be what Mitogen does (along with other improvements), a faster Ansible strategy [2].

[1] https://github.com/ansible/ansible/blob/becf9416736dc911d341...

[2] https://github.com/mitogen-hq/mitogen/blob/master/docs/ansib...

[nullify88 → throwdbaaway]

Thanks for the heads up, i'll give that a go :)