Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I'm not trying to be a huge asshole here, but this has zero tests and just saves json files to disk. There's literally a full readme and contributors guide but zero tests for something that's supposed to store data for you?

For a community that loves it some Jepsen analysis, I can't for the life of me figure out why this has been up-voted so many times. This is just saving JSON file to disk. I'd argue this is harder than using Redis (flushing to disk) or (vomits in mouth) Mongo. Or shit, just use your filesystem and `jq`, you'll have something likely faster, safer, and more maintainable.



What are you talking about? They have tests right here: https://github.com/Devs-Garden/jsonbase/blob/master/test.js

Just uncomment the tests you want to run! Easier than using a testing library IMO.


I can't tell if you're being serious but one of the main features of tests is they are automated. They should be able to run as part of the build.

And just because you're not using a library doesn't mean you shouldn't have assertions. All these "tests" do is log. What do I check the output for?

All you need to do to have a somewhat respectable build is uncomment those tests, make them clean up after themselves, change the console logging to be assertions instead, and make them run on GitHub.


Come on folks have some humor this is clearly sarcastic.




Consider applying for YC's Winter 2026 batch! Applications are open till Nov 10

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: