Hacker Newsnew | past | comments | ask | show | jobs | submitlogin
GitHub changes how authorship of sqush commits are attributed, breaks workflows (github.com/isaacs)
4 points by chrisgzf on March 5, 2020 | hide | past | favorite | 4 comments


Relevant GitHub comment:

> It looks like the change we've made has a bug in it which means the PR author isn't getting a co-author credit on the squashed commit. We're working on a fix for that now, and I think that's the cause of a large part of the problem here (and explains why you're not seeing the co-author show up in GitHub

> PRs with a single author are an interesting case. We originally considered doing the above in the case where the commit message is not changed during merging. Doing so would introduce an inconsistency with other squash and merge commits, though, so we wanted to ship and learn here. It's also worth noting that the command line equivalent, git merge --squash, makes the merger the author of the commit.


And already reverted


Not sure the revert is fully deployed yet, but it will be soon. This was my error at GitHub - happy to answer any questions about it.


I'm super impressed with how quickly this was identified as an issue and reverted.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: