On: Banned C standard library functions in Git source code

[Koshkin]

> strcpy ... BANNED

But they cannot ban while (* p++ = * q++); now can they.

[LukeShu → Koshkin]

It's not meant to be a substitute for humans reviewing patches. It's just meant to catch things new contributors are likely to try to use, and give them feedback on it before they send the patch to the mailing list.

[rat9988 → Koshkin]

Truly curious as I don't code in C, or any other low level language. What is the problem with it? That there might not be enough memory allocated at *q?

[microtherion → rat9988]

Not enough memory at *p. The loop performs the exact same function that strcpy does, and some people just write it out by hand.

[zsrxx → rat9988]

It doesn't stop until *p is \0, so yes