Hacker News new | past | comments | ask | show | jobs | submit login

Neat idea for showing off your design chops. I don’t use Twitter so I don’t have much feedback, other than your ad blocking code being brittle [1].

[1] https://github.com/thomaswangio/minimal-twitter/blob/e076507...




Thanks for pointing that out, I think I might remove it. Will cause more trouble down the road. Do you have any ideas to make it more safe?


Unfortunately, I can’t think of any. Twitter could arbitrarily change where those elements are placed in the DOM at any time (and they probably will to prevent other extensions from blocking promoted tweets). I would just consider this out of the scope of your project and not bother handling it.


Totally agreed, definitely out of scope. Just removed the script from the manifests. Thanks again!


You could potentially keep searching upwards for a parentNode that has role="article". While Twitter could change their markup significantly they sorta have to support screen readers so aria attributes will poke through here and there.


Hmmm interesting, if you have some time I'd love a PR. It would be a nice feature to have tbh


Thomas, I like your work. Just joined your newsletter. Would be interested to talk. I'm @ www.sendsmart.com


Sure, I'm at thomas [at] wang.sh!




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: