Hacker News new | past | comments | ask | show | jobs | submit login
Show HN: iOS Login Screen Written in Swift 4 (iosapptemplates.com)
6 points by floryan2oo7 on Jan 30, 2018 | hide | past | favorite | 3 comments



Not that you're asking for a code review but a couple things I noticed:

- You left your twitter IDs in your code. Not sure if it matters to you or not.

- Your buttons probably have some stuff in common (corner radius at least), so consider making the them all inherit from the base LoginButton class.

- You can put multiple lets on a single line, like `if let accessToken = AccessToken.current, let facebookAPIManager = FacebookAPIManager(accessToken: accessToken) {`


Nice, haha! I'll address your comments in a follow-up diff! Thanks!


Hi there! I hope you're enjoying the template! Please let me know if you have any feedback or ideas for improvements! Thank you!




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: