maxvisser's comments

On: Vaultwarden commit introduces SSO using OpenID Connect

[maxvisser]

Maybe if you deactiveer a users entra id that he cant access its vaultwarden vault anymore.

On: Amazon to display tariff costs for consumers

[maxvisser]

Some Amazon programmer tomorrow

priceIncrease := (newPrice - oldPrice) / oldPrice var trump_tariff bool

if priceIncrease > 1.0 { trump_tariff = true }

[unwind → maxvisser]

Please don't use if:s to assign boolean literals, just do it:

    const trump_tariff = priceIncrease > 1.0

also saves you from not initializing the variable in the default/other case. :)

[Upvoter33 → unwind]

This was just someone showing you what the "Amazon programmer" was doing, and hence a deep cut reference to the likelihood of it being poor quality code :)

[TheSoftwareGuy → Upvoter33]

If you really wanted to look like Amazon codex you would write Java :)

[maxvisser → TheSoftwareGuy]

I see I missed an opportunity to make it even funnier.

[throwaway519 → unwind]

    const

I feel you may underestimate how often they change.

[grokkedit → unwind]

not to mention the mix of snake_case & camelCase

[Someone → unwind]

In the original code, trump_tariff is a sticky value. If that’s intended/not intended, the above introduces/fixes a bug.

[ImHereToVote → unwind]

If statements are great because they are highly readable.

On: Firefox releases tab groups for nightly

[maxvisser]

I rather have something like arc does where you can anchor tabs on the sidebar as bookmarks. It feels a lot less chaotic.

[jay_kyburz → maxvisser]

Or, you know, just use bookmarks.

On: M4 MacBook Pro

[maxvisser]

Same for me. The only reason to replace it, is that my M1 pro’s SSD or battery will go bad or if I accidentally drop the machine and something breaks.

[rbanffy → maxvisser]

I am replacing a Dell laptop because the case is cracking, not because it's too slow (it isn't lightning fast, of course, but it sure is fast enough for casual use).

[fckgw → maxvisser]

I replaced my M1 Air battery last year and it's still going like a champ. $129 for another 3 years of life is a bargain.