Hacker News new | past | comments | ask | show | jobs | submit login
Show HN: Prophet – A financial micro-framework in Python (michaelsu.io)
152 points by Emsu on Nov 22, 2014 | hide | past | favorite | 32 comments



Very cool. I would like it even more if there were tests :)

https://github.com/Emsu/prophet/


Definitely adding tests :) The folder's sitting in my local repo and it'll be the next thing I do.


You posted the github link yourself... (Fork button is top right).


Can we stop making these responses every time anyone suggests a feature or critiques an open source project, please


Can we stop with the "I this doesn't match my ideology" critiques?


Actually, that's not how tests work. Writing a test after the code has been produced should not be considered a real test. Let me quote Robert C. Martin on this.

    If we lose the production code, we end up with a better designed system that stays clean because it has tests. If we lose the tests, then the production code rots and the team slows down in a never ending spiral of lost productivity.

    So we can conclude that if it became a choice between the tests or the production code, we'd rather preserve the tests. And this means that the tests are a more important component of the system than the production code is. Because the tests are the specs.
http://blog.8thlight.com/uncle-bob/2013/09/23/Test-first.htm...


Tests written after are still tests. It may not be 'test driven development', but they are still tests, and TDD is not the final answer IMHO.


nonsense!

these are still tests just as much as if they'd been written first, it's just a different methodology.


Very nice. I might replace my own personal framework with this - it's certainly cleaner.

A suggestion I'd make. Rather than simply taking a price series (which seems to be based on daily data), it might be useful to build based on the open/close/high/low series. Then allow the trades to happen at a random price between high/low rather than simply the close.

I find this more reflective of the uncertainty in trading since there is no reliable way to actually trade at the close price.


If you look at: https://github.com/Emsu/prophet/blob/master/prophet/data.py

There's a PandasDataGenerator which is a wrapper around the pandas libary's DataReader. For the Yahoo source, you can have the following data options: "Open", "High", "Low", "Close", "Volume", "Adj Close". The YahooCloseData generator actually uses "Adj Close". You can implement high, low or open by copying the YahooCloseData generator and getting the respective key instead of "Adj Close". Feel free to contribute these generators upstream too :)

If you're looking for modeling out the uncertainty, see the slippage section in:

http://prophet.michaelsu.io/en/latest/advanced.html#slippage...

If you have a dataset that provides more frequent than daily data, you can store the sell order on your order generator and process it the next tick. That combined with slippage and commission will probably give you the most accurate trading model.

Let me know if you have any other thoughts on how it can be better modeled.


Please don't use Adjusted Close for backtesting execution. Adjusted prices are not real. They never happened, and using them will add unknown error to your backtest results.

Back adjusted prices are fine for building a model, but when back testing the model and simulating executions, you should always use real prices.


You're right. I really need to bite the bullet and generate stock split data. That was the main reason I used adjusted because splits were skewing my tests a lot.


Why do you say you can't reliably get the closing price? You should be able to send an MOC order to the listing exchange to get the official closing price.


To be more precise, you can't reliably get the closing price and also know what it is before you get it.

If I understand the code right, it looks at the closing price and then decides if it wants to buy.

https://github.com/Emsu/prophet/blob/master/prophet/backtest...

Look at lines 72 and 79. The data in the examples comes from YahooCloseData in data.py.


Handling tick data even could help and be helped in the case you outlines above.


I actually really want to support it. If only I could get my hands on some tick data... any ideas?


You can get 1-minute price bars from Yahoo Finance:

http://finance.yahoo.com/_td_charts_api/resource/charts;comp...


I'll ping you on gh


This looks interesting. I'm familiar with the basics of investing, but have never gotten into quantitative analysis. Does anyone know of a good starting point (book, online course, anything)?


Might have a name clash issue with Sungard's iWorks Prophet, a commercial financial modelling tool.


Thanks for the heads up.


Looks good, I have been working on something similar recently but may just stop and use this. Would love to see the documentation fleshed out more.


Fleshed out the tutorial a bit more yesterday. Feel free to propose what kind of docs you'd like to see on the issues page. I'm all ears :)


Would love to see a how-to tutorial on using this to test and visualize different strategies on paper.


I'm adding a tutorial for more complicated strategies to the documentation. What did you have in mind for the visualization? Currently you can just install matplotlib and graph it or export a backtest to json.


Anybody know of any good apis to hook this thing into?


To start, free historical data from yahoo. Once you've back tested, try executing manually with your online brokerage (I.e. if it says buy, login to etrade and buy). After that upgrade to IB or Lime (depending on your needs).


Are there any frameworks that go well with Prophet?


The scipy and statsmodels libaries are nice. CVXOPT would be good for portfolio optimization. You really have to implement your own strategies though.


doesn't seem to work on Python 3.


I'll try to find some time to work on that. If you have time, it would be super awesome if you could make a pull request for python 3 compatibility.


Lastest master is Python 3 compatible.




Join us for AI Startup School this June 16-17 in San Francisco!

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: