Hacker News new | past | comments | ask | show | jobs | submit login

I thought Isaac accepted the Pull Request and merged it in? Doesn't he have the authority?



No. Not on the libuv project.

At the time of the controversy, the core developers of libuv were Ben Noordhuis (bnoordhuis), and Bert Belder (piscisaureus), both working for StrongLoop. Nothing is meant to be committed to the libuv tree without one of them signing off on it. To quote Ben's commit message: "@isaacs may have his commit bit but that does not mean he is at liberty to land patches at will. All patches have to be signed off by either me or Bert. Isaac, consider yourself chided."

But the very first comment on Ben's revert is from Bart: "I signed off on it. Just leave it as-is, no need to revert."

In short: Isaac did accept the pull request. He did not have the authority. Someone with authority (Bert) did accept it, however it was reverted (by Ben) under the mistaken belief that no one with authority had accepted it. A simple communication breakdown; why Bert didn't commit it himself (or why Isaac didn't note that he was committing it with Bert's authorisation) I'll never know.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: