Hacker News new | past | comments | ask | show | jobs | submit login

Unless I'm missing something, the example code will just calculate the checksum of "key:value&key:value&key:value", so actually anything with the same number of parameters will pass.

Assuming "key:value" is supposed to read "#{key}:#{value}", this may be vulnerable to a delimiter attack -- you couldn't tell the difference between {foo: 'bar', bar: 'baz'} and {foo: 'bar&bar:baz'}.




You are of course correct. Thanks! Will fix and rollout once traffic from HN/reddit dies down.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: