My big problem with NRA is how spammy they are to members. NRA-ILA is one thing, but being offered overpriced auto insurance, etc. all the time was really annoying. I eventually got off all the marketing lists, but it took a few tries.
However, they don't solve the problem that (you too have pointed out) of population gradually turning against gun ownership. If anything, railing against pop-culture makes them look like hypocrites and actively hurts the longer term (10+ years out) outlook.
I did rejoin the NRA just to add to their numbers; no doubt they'll support some stupid "compromise" soon enough again and I'll not renew, but for now I think it's the best thing, maladroit as they are.
I am not, BTW, under the impression that the population is "gradually turning against gun ownership". If that were true, how could we have had a nationwide sweep of shall issue concealed carry regimes from Florida in 1987 to Wisconson in 2011, totaling 42 states (with Vermont, Washington and maybe Indiana already having been there before it started)?
8 million outstanding licenses and counting, plus who knows in the 4 states with "Constitutional Carry" (no license required if you're not forbidden), Arizona having a substantial population (6.5 million, 15th in the nation).
And I don't believe the gun grabber propaganda that the same people are just buying more guns; for one extreme claim, someone did the math and came out with an average $100K investment per gun owning citizen.
But, yes, the NRA's pop-culture stuff, especially gaming, was an own goal and doesn't help in the long term. But there are plenty of RKBA types like myself who are happy to poison young people's minds about the NRA ^_^, so we'll see what happens after we get past the current mess.
Experiment: go to the range, find 10 men or women under the age of ~35 with AR-15s. Ask if they play first person shooters. Pretty sure over 75% will say "yes."
I am not an FPS person myself -- I like nethack and freeciv -- but aside from the fact that even violent video games are unambiguously protected by the first amendment, the demographics just can't be ignored.
"but aside from the fact that even violent video games are unambiguously protected by current first amendment jurisprudence"
You wouldn't have to go too far back for your original statement to be iffy or downright false; that said, I don't see this changing in the foreseeable future, but then again the Supremes are never entirely predictable.
The law overturned in Brown [originally -- in irony of all ironies -- Schwarzenegger] vs. Entertainment Merchants Association was created by a fellow who is currently better known for gems like these: