Hot take: I think the two will fall out within 6 months from when Trump takes office. Trump is notorious for screwing his contractors. Elon will want his ROI and Trump will at some point have enough.
That's what I expect, too. Say what you want about either man, they're both very cutthroat and self-interested. The minute either one stops being useful or pleasant enough to the other, they'll be done.