Hacker News new | past | comments | ask | show | jobs | submit login
The golden rule of PR reviews (jameshfisher.com)
2 points by dmarto on Oct 31, 2023 | hide | past | favorite | 3 comments



As always it depends. If that one improvement is paid for by more hacks (not just small inconsistencies), you start thinking. Adding hacks is linear, but their destructive effects are exponential because they start to interact. These places typically are never revisited but covered in more crust.

What if your colon surgeon bragged "Yes, I forgot the instrument in you, but the polyp is gone, so celebrate the improvement and shut up!"?


I hope I'm never again on a team with programmers like this guy.


Yeah, this is too far




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: