Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Despite all the negative comments, "Never fix a bug and refactor in the same pull request" is great advice and deserves reminders.


Why is it so great? Do you think the cost of doing it in the same pull request is greater than the cost of never refactoring at all, for example?


Personally it relates to the scope of the change/bugfix. Sometimes a nice refactor merge drags forever because the understanding of the fix/task you're working keeps changing until solidification, if it is an extensive refactor then it's more work to keep up with updates and conflicts.


- If you have to revert one of the two, you don't revert both

- You can deliver the two individual parts quicker




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: