I'm lead on a small team of web developers.
The other members consist of:
A Maverick who insists they know what they are doing but clearly don't and won't admit it. Going so far as to add concepts to the code that don't belong (or work for that matter), applying shiny new ideas from stackoverflow that bog down the system where a simple line will suffice.
Hour long tasks for them take a whol work week because of back and forth with PR comments.
The other member is a copy paster who will grab anything from anywhere (old projects, the web) and paste it in and expect something to happen (it doesn't).
I'm going on vacation and all PR's require my approval. I dread the mess I will have to sift through when I get back, could push the project back weeks.
What can I do in this situation?
I'm sure there are many thoughts going through your mind regarding the team and perhaps my lack of managment skills but I am only lead on the project, I don't manage people.
My boss trusts my judgement and is aware of the situation but he is not technical enough to take over the code reviews.
Is there a possible solution to this without adversely affecting the porject?
Thanks
Code that doesn’t work is an obvious problem; there needs to be a culture of reviewing your own work before it goes out for review. You also need to be more patient: I’m sure you write bugs, too.
But if _everyone but you_ isn’t comfortable working in a system, I don’t think that’s a problem with with those people, I think it’s a problem with that system.
It’s easy to get frustrated and say “eh, these people suck, let’s find new ones,“ but just like how it’s your job to solve the hard engineering problems, it’s also your job to get over it and find a way to actually work with these people.
If it _actually_ takes a week of back and forth for PRs to get merged, that means that there’s a massive problem with your review process. I’m going to guess that most of the time, this means that your comments are indirect, or worse. It’s your job to enable your colleagues to work faster, and if you don’t like that, you probably shouldn’t be a leader.