On: How to do a code review

[jdm2212]

It refers to "changelist". Google uses a Perforce-like VCS internally, and they kept the Perforce terminology: https://www.perforce.com/perforce/doc.051/manuals/p4guide/07...

[jonny_eh → jdm2212]

aka "Pull Request" in Github parlance.

[hota_mazi → jonny_eh]

aka "Merge Request" in Gitlab vernacular (which makes more sense than "pull request" in my opinion).

[aledalgrande → hota_mazi]

aka "patch" for the Linux kernel development community

[xixixao → aledalgrande]

aka "diff" or "revision" at FB .)

[o10449366 → xixixao]

aka "CR" or "Change Request" at Amazon

[sanderjd → hota_mazi]

Yeah, merge request seems like the best terminology of the ones I've seen.

[cpeterso → hota_mazi]

A Perforce changelist is more like a git commit than a GitHub pull request.

[jefftk → cpeterso]

The way Google uses it, a "CL" means both "a thing you sent out for pre-commit review" and "a submitted change". It's very similar to a GitHub PR, if you use a master branch and always squash your PRs when merging to master.