Hacker News
new
|
past
|
comments
|
ask
|
show
|
jobs
|
submit
login
jdm2212
on Sept 5, 2019
|
parent
|
context
|
favorite
| on:
How to do a code review
It refers to "changelist". Google uses a Perforce-like VCS internally, and they kept the Perforce terminology:
https://www.perforce.com/perforce/doc.051/manuals/p4guide/07...
jonny_eh
on Sept 5, 2019
[–]
aka "Pull Request" in Github parlance.
hota_mazi
on Sept 5, 2019
|
parent
[–]
aka "Merge Request" in Gitlab vernacular (which makes more sense than "pull request" in my opinion).
aledalgrande
on Sept 5, 2019
|
root
|
parent
|
next
[–]
aka "patch" for the Linux kernel development community
xixixao
on Sept 6, 2019
|
root
|
parent
|
next
[–]
aka "diff" or "revision" at FB .)
o10449366
on Sept 6, 2019
|
root
|
parent
|
next
[–]
aka "CR" or "Change Request" at Amazon
sanderjd
on Sept 6, 2019
|
root
|
parent
|
prev
|
next
[–]
Yeah, merge request seems like the best terminology of the ones I've seen.
cpeterso
on Sept 5, 2019
|
root
|
parent
|
prev
[–]
A Perforce changelist is more like a git commit than a GitHub pull request.
jefftk
on Sept 5, 2019
|
root
|
parent
[–]
The way Google uses it, a "CL" means both "a thing you sent out for pre-commit review" and "a submitted change". It's very similar to a GitHub PR, if you use a master branch and always squash your PRs when merging to master.
Consider applying for YC's Spring batch! Applications are open till Feb 11.
Guidelines
|
FAQ
|
Lists
|
API
|
Security
|
Legal
|
Apply to YC
|
Contact
Search: