I would be careful, a critical buffer overflow vulnerability was just found in ...

ramchip · on Jan 22, 2017

Comments like this never fail to make me smile:

    +  // Don't do anything if the process_path length is > PATH_LENGTH
    +  if (strlen(process_path) > PATH_LENGTH)
    +    return;

ori_b · on Jan 22, 2017

And it's still wrong, since strncpy() doesn't null terminate: it null pads. That means that if the string is longer than the buffer, it will not be correctly terminated.

iMerNibor · on Jan 22, 2017

They do check the string size before using strncpy though, so it should be fine

ori_b · on Jan 22, 2017

The check is off by one. If it's equal in length to the buffer, then the buffer will not be nul terminated.

q3k · on Jan 22, 2017

strcpy() in a kernel module. This is quite horrifying.